tools: add more automation for labeling - #65059
Conversation
Signed-off-by: avivkeller <me@aviv.sh>
Signed-off-by: avivkeller <me@aviv.sh>
|
Review requested:
|
nodejs-github-bot
added
meta
|
I don't think either one of those is a good idea.
author ready
Many a time this is not an indication of an author ready PR. Possibly for outside contributions, but for collaborators who "author" and drive their own PRs to completion this isn't case. A review may fly in while i'm running full CI to figure out a failure. Not a ready PR.
commit-queue
That's just asking for trouble |
|
The
So I based the criteria off of that, perhaps I can change it to only run when there's a passing CI and none in progress?
Hypothetically it hopefully shouldn't, it'll only run on PRs that are ready to land, no? |
|
+1 to panva's sentiments. I do get the motivation, but I think that a workflow that gives potentially-mergeable PRs a "nudge" after a couple of weeks (just a comment or something similar) would be far more appropriate. One definition for this could be a PR with one or more collaborator approvals, and no failures from GHA's own check suites (ie. excluding Jenkins failures). |
|
We currently have 76 author ready issues, many of which are probably no longer author ready, due to conflicts and whatnot. The goal here is to reduce the maintenance burden on collaborators by automating that landing process more than it currently is. I really think at least some level of automation in this regarding is a step towards cleaning up our issue tracker. Perhaps just automating |
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
I don't like the outcomes of this when dismisses non-thread comments (that do not have a "resolve" button) and the automation could also kick in an ongoing discussion, unnecessarily causing confusions.
I'd prefer Rene's suggestion that this should nudge on PRs which are already labeled but not moving forward, rather than automatic labeling.
| # | ||
| # * there is a CI run in progress or completed, | ||
| # * there is at least one collaborator approval, | ||
| # * there are no outstanding review comments. |
There was a problem hiding this comment.
Review comments can be plain comments. This automation only counts GitHub inline code review comments (only these comments have a "resolve" button).
5 participants
Recently, we changed our stale bot to collect issues and PRs at a much more aggressive rate, and we should see the fruits of that in a few weeks (I think 2?).
However, part of preventing stale and stalled PRs is merging them in a timely fashion, so this PR adds the following automations:
The
author readylabel is added to a PR when:The
commit-queuelabel is added to a PR when:author readylabel)main, andmergeableis not CONFLICTINGneeds-cimainhas not moved oncommit-queue-failed) or a blocked labelblocked,wip, etccc @nodejs/TSC